feat(js): Switch to non experimental option for logs #14460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
stephanie-anderson and
andreiborza
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 180 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
andreiborza
approved these changes
Jul 25, 2025
| {/* ATTENTION: The rules defined here must match those in the app's onboarding documentation (see: https://github.com/getsentry/sentry/blob/master/static/app/gettingStartedDocs/javascript/javascript.tsx). | ||
| If you make any changes, please update the getting started doc accordingly. */} | ||
|
|
||
| {/_ ATTENTION: The rules defined here must match those in the app's onboarding documentation (see: https://github.com/getsentry/sentry/blob/master/static/app/gettingStartedDocs/javascript/javascript.tsx). |
There was a problem hiding this comment.
q: Is this change intentional?
There was a problem hiding this comment.
this was done by prettier autoformatting. From what I can see it doesn't change behaviour.
There was a problem hiding this comment.
I don't know what prettier has been smoking but this definitely broke all these sections:
Error occurred during MDX compilation: [
[2] {
[2] detail: [5:3: Could not parse expression with acorn] {
[2] ancestors: undefined,
[2] column: 3,
[2] fatal: true,
[2] line: 5,
[2] place: { line: 5, column: 3, offset: 409 },
[2] reason: 'Could not parse expression with acorn',
[2] ruleId: 'acorn',
[2] source: 'micromark-extension-mdx-expression',
[2] url: 'https://github.com/micromark/micromark-extension-mdx-expression/tree/main/packages/micromark-extension-mdx-expression#could-not-parse-expression-with-acorn',
[2] file: '',
[2] [cause]: SyntaxError: Invalid regular expression: /_ ATTENTION: The rules defined here must match those in the app's onboarding documentation (see: https:/: Unterminated group
[2] at new Promise (<anonymous>) {
[2] pos: 409,
[2] loc: { line: 5, column: 2 },
[2] raisedAt: 105
[2] }
[2] },
[2] id: '',
[2] location: {
[2] column: 2,
[2] file: '_mdx_bundler_entry_point-9a70eec9-d7c4-49a0-96f0-c8681317e780.mdx',
[2] length: 1,
[2] line: 5,
[2] lineText: "{/_ ATTENTION: The rules defined here must match those in the app's onboarding docu",
[2] namespace: 'file',
[2] suggestion: ''
[2] },
[2] notes: [],
[2] pluginName: '@mdx-js/esbuild',
[2] text: 'Could not parse expression with acorn'
[2] }
[2] ]
Don't know why or how this keeps building on prod. Will be sending a PR to fix this.
Comment on lines
+5
to
+6
| {/_ ATTENTION: The rules defined here must match those in the app's onboarding documentation (see: https://github.com/getsentry/sentry/blob/master/static/app/gettingStartedDocs/javascript/nextjs.tsx). | ||
| If you make any changes, please update the getting started doc accordingly. _/} |
Comment on lines
+5
to
+6
| {/_ ATTENTION: The rules defined here must match those in the app's onboarding documentation (see: https://github.com/getsentry/sentry/blob/master/static/app/gettingStartedDocs/node/node.tsx). | ||
| If you make any changes, please update the getting started doc accordingly. _/} |
Comment on lines
+5
to
+6
| {/_ ATTENTION: The rules defined here must match those in the app's onboarding documentation (see: https://github.com/getsentry/sentry/blob/master/static/app/gettingStartedDocs/javascript/react.tsx). | ||
| If you make any changes, please update the getting started doc accordingly. _/} |
lucas-zimerman
pushed a commit
that referenced
this pull request
Jul 29, 2025
Builds on top of #14449, catches a bunch of stuff that I missed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #14449, catches a bunch of stuff that I missed.